-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gamera spectral model example #28
base: master
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gschwefer . This is interesting but I think we have a practical issue here.
For this recipe to run, gamera must be installed via the conda environment here.This would require a much more complex scheme where the Action will git clone and make gamera before running the notebook...
@registerrier and @gschwefer I agree making |
@adonath @registerrier We are trying to make that happen. It should already work with:
|
This is really cool @maxnoe ! I have first run
I tried to set the env variable but it did not work. Any idea? |
For compiling things in the conda env, also install the That makes sure everything is setup correctly for libraries to be found. Side note: swig is not needed in the conda env, it's only a build time dependency and is installed in the build env automatically. |
Thanks. It worked! |
Hello everyone,
this PR contains an example of how to use the Gamera source modelling tool to fit spectra in gammapy.
There are essentially two ways, one is to subclass
SpectralModel
with aGameraSpectralModel
, the other to use aTemplateNDSpectralModel
One Problem with this is that gamera is not pip installable, therefore the notebook can't just be run after installing the environment from the
env.yml
, it requires the extra installation of gamera. A link to the installation info i in the notebook, but of course this is not ideal. Do you have any other suggestions for how to deal with this?Also, are there any figures you would like to see added to this notebook?