Add licences for the remaining data #57
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Khélifi <[email protected]>
Signed-off-by: Bruno Khélifi <[email protected]>
Signed-off-by: Bruno Khélifi <[email protected]>
Signed-off-by: Bruno Khélifi <[email protected]>
Signed-off-by: Bruno Khélifi <[email protected]>
Signed-off-by: Bruno Khélifi <[email protected]>
|
The license for the MAGIC data is missing. Do not merge it now |
QRemy
reviewed
Jul 16, 2024
AtreyeeS
requested changes
Jul 16, 2024
There was a problem hiding this comment.
Thank you @bkhelifi !
I have some small inline comments/questions.
Do we not need licenses also for
- https://github.com/gammapy/gammapy-data/tree/main/PKS2155-steady
- https://github.com/gammapy/gammapy-data/tree/main/cta-caldb
- https://github.com/gammapy/gammapy-data/tree/main/joint-crab/dl3/magic (for the MAGIC data)
- https://github.com/gammapy/gammapy-data/tree/main/magic/rad_max (again for the MAGIC data)
| - Reference: `Zhen Cao et al. 2024 ApJS 271 25 <https://iopscience.iop.org/article/10.3847/1538-4365/acfd29>`_ | ||
| - Licence: The First LHAASO Catalog of Gamma-Ray Sources © 2023 by The LHAASO | ||
| Collaboration is licensed under `CC BY-NC-SA 4.0 <https://creativecommons.org/licenses/by-nc-sa/4.0/>`_. | ||
| - 2HWC: |
There was a problem hiding this comment.
I am wondering if the main catalogs readme should also list the Fermi Catalogs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the feedback of the associated collaborations.