Fixes #4758, set the correct parameter memory and size for DwmSetWindowAttribute and DWMWA_USE_IMMERSIVE_DARK_MODE on windows. #5180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steampoweredtaco
force-pushed
the
fixWindowsThemeSetting-4758
branch
from
1effa92
to
58fbca9
Compare
…SetWindowAttribute and DWMWA_USE_IMMERSIVE_DARK_MODE on windows.
steampoweredtaco
force-pushed
the
fixWindowsThemeSetting-4758
branch
from
58fbca9
to
a902d27
Compare
andydotxyz
previously approved these changes
Oct 5, 2024
|
My apologizes for the lint issue, things reformatted looked good on my end but was wrong. After seeing what the workflow does I was able to use goimports directly and confirm I resolved whitespace format issue. Updated. |
andydotxyz
approved these changes
Oct 5, 2024
|
Merging, the test error is something from before this PR that we are working on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For windows this will set the correct parameter memory and size for DmwSetWindowAttribute and DWMWA_USE_IMMERSIVE_DARK_MODE. This resolves random memory access errors and that immersive mode might sometimes be set incorrectly as seen by the wrong color title bar.
Fixes #4758
Checklist:
all pass. - No, but all my errors appear unrelated and based on window specific testing issues: testlog.txt