Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest breaking API changes in go-text #5169

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

andydotxyz
Copy link
Member

As happens sometimes the repo had an API break and so people upgrading all their deps get compile errors.
This resolves this and will be picked to release branch as well.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 66.032% (+0.005%) from 66.027%
when pulling 7fb896c on andydotxyz:fix/gotextapichanges
into 119d2f8 on fyne-io:develop.

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gosh how I wish people would stop doing bad stuff :/

Anyway, nice change and hopefully no problems going forward then :)

@andydotxyz
Copy link
Member Author

Gosh how I wish people would stop doing bad stuff :/

Anyway, nice change and hopefully no problems going forward then :)

Yeah. Though isn't that what we said last time?

I wonder if we should go ahead and fork so we can manage in the unfortunate situation there are ever future breaks?

@andydotxyz andydotxyz merged commit 517e48f into fyne-io:develop Sep 30, 2024
12 checks passed
@andydotxyz andydotxyz deleted the fix/gotextapichanges branch September 30, 2024 19:47
@Jacalz
Copy link
Member

Jacalz commented Sep 30, 2024

It should definitely safer and especially from breaking changes in the renderer (given that it has a tagged release now) but people can always forcefully update dependencies.

But I really don't think we should fork anything just because the dependency is making breaking changes. We'd add extra work for ourselves without anything to gain. The ones updating our own dependencies to versions with breaking changes are the ones to blame here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants