Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check with display PoC #5165

Closed
wants to merge 1 commit into from
Closed

Check with display PoC #5165

wants to merge 1 commit into from

Conversation

flimzy
Copy link
Contributor

@flimzy flimzy commented Sep 27, 2024

Description:

Proof-of-concept for adding optional display text to Check widgets, following Slack discussion.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style and have Since: line.
  • Any breaking changes have a deprecation path or have been discussed.
  • Check for binary size increases when importing new modules.

@flimzy flimzy changed the base branch from master to develop September 27, 2024 14:15
@coveralls
Copy link

coveralls commented Sep 27, 2024 •
edited
Loading

Coverage Status

coverage: 66.037% (+0.01%) from 66.027%
when pulling d1a301c on flimzy:checkWithDisplayPoC
into 119d2f8 on fyne-io:develop.

@andydotxyz
Copy link
Member

It's not clear here what Display adds here over Text. Both are just putting a string representation for describing the item being turned on/off

@flimzy flimzy closed this Oct 15, 2024
@flimzy flimzy deleted the checkWithDisplayPoC branch October 15, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flimzy @coveralls @andydotxyz