Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/driver/mobile: return storage.ErrNotExists instead of custom error #5151

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

pierrec
Copy link

@pierrec pierrec commented Sep 17, 2024

Description:

Use a standard error instead of a custom one on Android.

Fixes #3353.

Checklist:

Did not add any test as the change is really trivial.

@pierrec pierrec changed the title Issue3353 internal/driver/mobile: return storage.ErrNotExists instead of custom error Sep 17, 2024
@pierrec
Copy link
Author

pierrec commented Sep 17, 2024

Hmm not sure why github insists of putting it into master...
Edit: fixed.

@pierrec pierrec changed the base branch from master to develop September 17, 2024 19:55
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Nice catch :)

@Jacalz Jacalz merged commit 1ea14f7 into fyne-io:develop Sep 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app.Storage.Open() to return a known error when file not exist
2 participants