added a search bar to the file dialog #5144
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the search bar takes advantage of the existing filtering system in order to only show files or filders that match a specific prompt. for now, there is no way to recursively search through files, or use something like regex, though that could be added as options later. the main internal change needed is, in order to be backwards compatible, having a list of filters instead of just a single filter at a time. that way, library users can still have many filters while including the search bar.
billyb2
force-pushed
the
billy/file_dialog_search
branch
from
274d464
to
828ea2f
Compare
|
Still have yet to add tests to this, so I haven't put it up for proper review yet. I don't expect to change much about the implementation though, unless the fyne team want changes :) |
|
Yeah apologies I slipped and tapped the wrong button when trying to kick off tests. |
no worries :). any time reviewing this is great, i appreciate the amazing work yall are doing. |
Before adding more tests better fix the ones that broke ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the search bar takes advantage of the existing filtering system in order to only show files or filders that match a specific prompt. for now, there is no way to recursively search through files, or use something like regex, though that could be added as options later.
the main internal change needed is, in order to be backwards compatible, having a list of filters instead of just a single filter at a time. that way, library users can still have many filters while including the search bar.
Description:
Fixes #4195
Checklist: