Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyperlink: Invoke OnTapped callback when typing space bar while focused #4112

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Hyperlink: Invoke OnTapped callback when typing space bar while focused #4112

merged 1 commit into from
Aug 1, 2023

Conversation

dweymouth
Copy link
Contributor

Description:

The Hyperlink widget can be activated by typing the space bar while focused in addition to tapping it, but the key event handler did not invoke the user-supplied OnTapped callback if set.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

@coveralls
Copy link

Coverage Status

coverage: 66.356% (+0.02%) from 66.332% when pulling 8eb490c on dweymouth:hyperlink-keyboard-ontapped into 082c2be on fyne-io:develop.

andydotxyz
andydotxyz approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch thanks

@dweymouth dweymouth merged commit 0c031a5 into fyne-io:develop Aug 1, 2023
11 checks passed
@dweymouth dweymouth deleted the hyperlink-keyboard-ontapped branch August 1, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dweymouth @coveralls @andydotxyz