Fix potential infinite loop (create renderer -> refresh -> create renderer) in menu item #4105

andydotxyz · 2023-07-29T15:31:19Z

This was uncommon but could happen.
CreateRenderer should never initiate a Refresh as it can always reach this infinite loop.

Checklist:

Tests included. <- not possible in test driver with its threading model
Lint and formatter run with no errors.
Tests all pass.

…derer) in menu item

coveralls · 2023-07-29T15:35:11Z

coverage: 66.188% (+0.005%) from 66.183% when pulling 4669b0f on andydotxyz:fix/menusetuploop into fe90859 on fyne-io:develop.

Jacalz

Looks good. I think this might solve #4086 but I'm not sure. Started fyne_demo around 30 times without it happening. I am not sure how often it occurred before so it is hard to say if it was just a coincidence or not.

Fix potential infinite loop (create renderer -> refresh -> create ren…

4669b0f

…derer) in menu item

Jacalz approved these changes Jul 29, 2023

View reviewed changes

andydotxyz merged commit 082c2be into fyne-io:develop Jul 30, 2023
11 checks passed

andydotxyz deleted the fix/menusetuploop branch July 30, 2023 18:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix potential infinite loop (create renderer -> refresh -> create renderer) in menu item #4105

Fix potential infinite loop (create renderer -> refresh -> create renderer) in menu item #4105

andydotxyz commented Jul 29, 2023

coveralls commented Jul 29, 2023

Jacalz left a comment

Fix potential infinite loop (create renderer -> refresh -> create renderer) in menu item #4105

Fix potential infinite loop (create renderer -> refresh -> create renderer) in menu item #4105

Conversation

andydotxyz commented Jul 29, 2023

Checklist:

coveralls commented Jul 29, 2023

Jacalz left a comment

Choose a reason for hiding this comment