-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix possible Windows GPU multiple window crash #4081
Conversation
…t share on some Windows GPU Fixes fyne-io#4000
👍 Works great here. Verified develop failed, then that fix/4000 passed. nVidia GeForce RTX 2080 Ti on Windows 11. That looks like it was "fun". Thankyou! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I haven't been able to reproduce the issue myself, the code does look good and works fine on my computer. Well done!
Just had one not inline about a file that probably shouldn't be deleted. Consider it approved after that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some swear word I want to use about GL driver. Good catch. Thanks for tracking this down.
This was a real pain!
On some GPUs the new shaders would crash when in the background.
It appears to be like the discovered webGL issue before but worse.
This fix addresses both at the same time.
Tested in Windows Intel, webGL and also GLES code paths.
Fixes #4000
Checklist: