Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible Windows GPU multiple window crash #4081

Merged
merged 4 commits into from
Jul 22, 2023

Conversation

andydotxyz
Copy link
Member

@andydotxyz andydotxyz commented Jul 21, 2023

This was a real pain!
On some GPUs the new shaders would crash when in the background.
It appears to be like the discovered webGL issue before but worse.
This fix addresses both at the same time.

Tested in Windows Intel, webGL and also GLES code paths.

Fixes #4000

Checklist:

  • Tests included. <- see the issue for steps (you'll need the right GPU)
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Jul 21, 2023

Coverage Status

coverage: 66.189% (-0.02%) from 66.204% when pulling 8ddd2ef on andydotxyz:fix/4000 into 19e0c73 on fyne-io:develop.

@Goltanju
Copy link
Contributor

👍 Works great here. Verified develop failed, then that fix/4000 passed. nVidia GeForce RTX 2080 Ti on Windows 11.

That looks like it was "fun". Thankyou!

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I haven't been able to reproduce the issue myself, the code does look good and works fine on my computer. Well done!

Just had one not inline about a file that probably shouldn't be deleted. Consider it approved after that :)

cmd/hello/FyneApp.toml Show resolved Hide resolved
Bluebugs
Bluebugs previously approved these changes Jul 22, 2023
Copy link
Contributor

@Bluebugs Bluebugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some swear word I want to use about GL driver. Good catch. Thanks for tracking this down.

@andydotxyz andydotxyz merged commit 1626a09 into fyne-io:develop Jul 22, 2023
11 checks passed
@andydotxyz andydotxyz deleted the fix/4000 branch July 22, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants