Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't write out 'LinuxAndBSD' section on every package #4070

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Don't write out 'LinuxAndBSD' section on every package #4070

merged 1 commit into from
Jul 19, 2023

Conversation

andydotxyz
Copy link
Member

Make it optional instead :)

Checklist:

  • Tests included. <- I think we have omitted the serialising of TOML from tests?...
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz andydotxyz requested a review from Jacalz July 19, 2023 08:04
@coveralls
Copy link

Coverage Status

coverage: 66.194% (-0.008%) from 66.202% when pulling f05c4e4 on andydotxyz:fix/optionalmetadata into 940dcdc on fyne-io:develop.

Jacalz
Jacalz approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. I 100% agree with you about it not being added to every package :)

@andydotxyz andydotxyz merged commit a18fbe5 into fyne-io:develop Jul 19, 2023
11 checks passed
@andydotxyz andydotxyz deleted the fix/optionalmetadata branch July 19, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andydotxyz @coveralls @Jacalz