Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph to nx hyperedge #19

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Graph to nx hyperedge #19

wants to merge 2 commits into from

Conversation

cmalinmayor
Copy link
Collaborator

Proposed Change

Deal with hyperedges in the graph_to_nx function. Note: This involves pinning motile to v0.3.0 and above, breaking lots of backward compatibility.
Another option is to move the graph_to_nx function into motile where it belongs.

Checklist

  • I have added tests that prove that my feature works in various situations or tests the bugfix (if applicable).
  • I have checked that the tests pass and I maintained or improved test coverage (if applicable).
  • I have written docstrings and checked that they render correctly in the documentation build.
  • I have checked that mypy type checking passes.

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@cmalinmayor cmalinmayor marked this pull request as draft August 16, 2024 03:41
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 85.03%. Comparing base (cdc12a4) to head (1b84215).

Files Patch % Lines
src/motile_toolbox/candidate_graph/graph_to_nx.py 37.50% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   86.88%   85.03%   -1.86%     
==========================================
  Files          14       14              
  Lines         427      441      +14     
==========================================
+ Hits          371      375       +4     
- Misses         56       66      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants