Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug in scip freeConstraints and gurobi setConstraints crash #44

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Nov 8, 2023

This fixes the SCIP freeConstraints no-op bug... but there is still a crash in the gurobi backend (that should appear in the tests now) ... and bug in gurobi clear is also fixed

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #44 (5d3ec1b) into main (d1fb38d) will decrease coverage by 25.97%.
Report is 1 commits behind head on main.
The diff coverage is 23.52%.

@@             Coverage Diff             @@
##             main      #44       +/-   ##
===========================================
- Coverage   91.90%   65.93%   -25.97%     
===========================================
  Files           4       17       +13     
  Lines         383      822      +439     
  Branches        0      155      +155     
===========================================
+ Hits          352      542      +190     
- Misses         31      219      +188     
- Partials        0       61       +61     
Files Coverage Δ
ilpy/impl/solvers/GurobiBackend.h 0.00% <ø> (ø)
ilpy/impl/solvers/ScipBackend.cpp 60.52% <50.00%> (ø)
ilpy/impl/solvers/GurobiBackend.cpp 9.02% <0.00%> (ø)

... and 11 files with indirect coverage changes

@tlambert03 tlambert03 changed the title fix: fix scip freeConstraints fix: fix bug in scip freeConstraints and gurobi setConstraints crash Nov 9, 2023
Copy link
Member

@funkey funkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I think there is a potential memory leak in ScipBackend, otherwise looks good to me.

ilpy/impl/solvers/ScipBackend.cpp Show resolved Hide resolved
@tlambert03 tlambert03 merged commit 7fac186 into funkelab:main Nov 10, 2023
15 of 17 checks passed
@tlambert03 tlambert03 deleted the test-set-constraints branch November 10, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants