Fix Unet cropping for same padding #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `same` padding, the output size of a Unet should be equal to its input size. The cropping function in `Upsample` that ensures translation equivariance with the total upsampling factor for nets with `valid` padding breaks this assumption for certain Unet instances. However, a Unet instance with `same` padding cannot be translation-equivariant, therefore the cropping mechanism should not be used for nets with `valid` padding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
samepadding, the output size of a Unet should be equal to its input size.The cropping function in
Upsamplethat ensures translation equivariancewith the total upsampling factor for nets with
validpadding breaks thisassumption for certain Unet instances.
However, a Unet instance with
samepadding cannot be translation-equivariant,therefore the cropping mechanism should not be used for nets with
validpadding.This PR also fixes a small typo in the Unet tests and adds a new test for Unets with
samepadding.