Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resourceId from eventSource if it exists #418

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

julienboulay
Copy link

This pull request allow to add resourceId defined on an eventSource and propagate it to the eventDef.
Fixes issue https://github.com/fullcalendar/fullcalendar-scheduler/issues/124

@acerix
Copy link
Member

acerix commented Feb 5, 2018

Thanks for the PR

@arshaw
Copy link
Member

arshaw commented Mar 4, 2018

thanks for this @julienboulay . i want to merge this. could you please first sign this? https://docs.google.com/forms/d/e/1FAIpQLScU-HzFWsMRe1YcC_flGjIFRV_xm8nzRz1bIzUzSOMoA3AevQ/viewform?c=0&w=1

@julienboulay
Copy link
Author

@arshaw : I've signed the agreement. Just one remark before merging. It seems that this code is obsolete and I could manage the resourceId with eventDataTransform.
Not sure that this pullrequest is necessary actually

@arshaw
Copy link
Member

arshaw commented Mar 11, 2018

thanks @julienboulay . i think this feature is still valuable. it's more elegant that using eventDataTransform

@arshaw
Copy link
Member

arshaw commented Mar 11, 2018

if you get a chance, could you write an automated test? https://github.com/fullcalendar/old-docs/blob/wiki/Automated-Tests.md

@arshaw arshaw changed the title Extract resourceId from eventSource if it exists Use resourceId from eventSource if it exists Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants