Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds optional menu to rename workspaces #11

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

rk1a
Copy link

@rk1a rk1a commented Dec 30, 2021

Hi, I added a simple menu to directly rename workspaces.
image
When it is enabled in the preferences, a right click on the workspace bar opens the menu, a left click switches to the clicked workspace as before.

@fthx
Copy link
Owner

fthx commented Jan 3, 2022

Hi, thanks for that.
Could you test your version for some time and check logs ("fthx", "js") to see if there is any error/warning?
Right now I don't have the time to review all that, but fast renaming is in the scope of this extension as it's used by a lot of people.

@rk1a
Copy link
Author

rk1a commented Jan 3, 2022

Hi, thanks for that. Could you test your version for some time and check logs ("fthx", "js") to see if there is any error/warning? Right now I don't have the time to review all that, but fast renaming is in the scope of this extension as it's used by a lot of people.

Hi, sure, checking logs while clicking the bar always gives me an error which is however unrelated to the code I added:

JS ERROR: TypeError: dockManager is null
getRunningApps@/usr/share/gnome-shell/extensions/[email protected]/locations.js:653:9
wrapWindowsManagerApp/fileManagerApp._updateWindows@/usr/share/gnome-shell/extensions/[email protected]/locations.js:258:9
wrapWindowsManagerApp/windowsChangedId<@/usr/share/gnome-shell/extensions/[email protected]/locations.js:250:24
_toggle_ws@/home/me/.local/share/gnome-shell/extensions/workspaces-bar@fthx/extension.js:124:62
_update_ws/<@/home/me/.local/share/gnome-shell/extensions/workspaces-bar@fthx/extension.js:114:59

With my version I see this log message times the number of workspaces when first right-clicking on the bar and when I rename the workspaces:

clutter_input_focus_set_cursor_location: assertion 'clutter_input_focus_is_focused (focus)' failed

But there is no indication from where..

btw, I'm on gnome 40.4.0

- ws name array is updated according to num ws
- when renaming whitespaces are trimmed
- only small names are padded in ws bar
@fthx
Copy link
Owner

fthx commented Feb 9, 2022

I will look at this soon, during holidays.

@muhammad-saleh
Copy link

@fthx Did you have time to look into this? I think it will be a great add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants