Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments and tests for Seq module #331

Merged
merged 7 commits into from
May 18, 2024
Merged

Comments and tests for Seq module #331

merged 7 commits into from
May 18, 2024

Conversation

kevmal
Copy link
Contributor

@kevmal kevmal commented May 10, 2024

Closes #329, Closes #330

[Required] please make sure you checked that

  • The project builds without problems on your machine

[Optional]

  • Added unit tests regarding the added features

bvenn
bvenn approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@bvenn bvenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for all these changes 🚀

@bvenn bvenn merged commit 9d663b4 into fslaborg:developer May 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvenn bvenn bvenn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Seq.stats returns wrong seq length (N) [BUG] Seq.weightedMean returns a function
2 participants
@kevmal @bvenn