Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove AutoOpen on Seq, List and Array modules, define RequireQualifiedAccess on them. #320

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

smoothdeveloper
Copy link
Contributor

Closes #312

Description

There are few shenanigans with FSharp.Stats.DistanceMetrics.Vector and FSharp.Stats.DistanceMetrics which needs to be open in a non intuitive order, please let me know if you prefer I rejig this in some way.

I think one approach would be to put RequireQualifiedAccess for the Vector module, but would incur more impact in client code.

https://learn.microsoft.com/en-us/dotnet/fsharp/style-guide/component-design-guidelines#consider-using-requirequalifiedaccess-and-carefully-apply-autoopen-attributes

  • The project builds without problems on your machine
  • Added unit tests regarding the added features
  • Checked the documentation builds and gave it a quick look

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.83333% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 47.61%. Comparing base (557ee8a) to head (73ee371).
Report is 2 commits behind head on developer.

Files Patch % Lines
src/FSharp.Stats/Correlation.fs 0.00% 2 Missing ⚠️
src/FSharp.Stats/Vector.fs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           developer     #320      +/-   ##
=============================================
+ Coverage      47.56%   47.61%   +0.05%     
=============================================
  Files            151      152       +1     
  Lines          16726    16765      +39     
  Branches        2253     2253              
=============================================
+ Hits            7956     7983      +27     
- Misses          8082     8097      +15     
+ Partials         688      685       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvenn bvenn merged commit 3533493 into fslaborg:developer Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] review / remove [<AutoOpen>] on modules that overlay FSharp.Core collection types.
3 participants