remove AutoOpen on Seq, List and Array modules, define RequireQualifiedAccess on them. #320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #312
Description
There are few shenanigans with
FSharp.Stats.DistanceMetrics.Vector
andFSharp.Stats.DistanceMetrics
which needs to be open in a non intuitive order, please let me know if you prefer I rejig this in some way.I think one approach would be to put
RequireQualifiedAccess
for theVector
module, but would incur more impact in client code.https://learn.microsoft.com/en-us/dotnet/fsharp/style-guide/component-design-guidelines#consider-using-requirequalifiedaccess-and-carefully-apply-autoopen-attributes