Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Dunn-Šidák #179

Open
wants to merge 4 commits into
base: developer
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/FSharp.Stats/Testing/MultipleTesting.fs
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,19 @@ module MultipleTesting =
|> Seq.ofList


// adapted from: https://en.wikipedia.org/wiki/%C5%A0id%C3%A1k_correction & https://personal.utdallas.edu/~herve/Abdi-Bonferroni2007-pretty.pdf
// checked according to: https://cran.r-project.org/web/packages/aggregation/index.html
// original derivation: https://www.tandfonline.com/doi/abs/10.1080/01621459.1967.10482935
/// <summary>Computes the Dunn-Sidak correction onto a collection of p-values with a given alpha.</summary>
/// <returns>Returns a critical value.</returns>
/// <remarks>p-values above the critical value should be rejected. Use this correction to reduce family-wise error rate when performing multiple tests on a dataset. p-values above 1, below 0, inf, and nan are excluded.</remarks>
let dunnSidak alpha (pValues : seq<float>) =
let checkedValues = Seq.filter (fun v -> v >= 0. && v <= 1.) pValues
let m = float (Seq.length checkedValues)
let criticalValue = 1. - (1. - alpha) ** (1. / m)
criticalValue


// John D. Storey
// http://dldcc-web.brc.bcm.edu/lilab/liguow/CGI/R/library/qvalue/html/qvalue.html
// http://qvalue.princeton.edu/
Expand Down
17 changes: 17 additions & 0 deletions tests/FSharp.Stats.Tests/Testing.fs
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,23 @@ let benjaminiHochbergTests =
]


[<Tests>]
let dunnSidakTest =
// taken from: https://web.archive.org/web/20200723122809/https://www.real-statistics.com/hypothesis-testing/familywise-error/bonferroni-and-dunn-sidak-tests/
let testPvalues = [0.01208; 0.00356; 0.11542; 0.02155; 0.03329; 0.01042]
let testAlpha1 = 0.05
let testAlpha2 = 0.01
let expectedValue1 = 0.008512
let expectedValue2 = 0.001674
let observedValue1 = MultipleTesting.dunnSidak testAlpha1 testPvalues |> round 6
let observedValue2 = MultipleTesting.dunnSidak testAlpha2 testPvalues |> round 6
testList "Testing.MultipleTesting.dunnSidak" [
testCase "Alpha = 5 %" <| fun () ->
Expect.floatClose Accuracy.veryHigh observedValue1 expectedValue1 "corrected p values are about equal."
testCase "Alpha = 1 %" <| fun () ->
Expect.floatClose Accuracy.veryHigh observedValue2 expectedValue2 "corrected p values are about equal."
]


[<Tests>]
let qValuesTest =
Expand Down