Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stateful Storage Pallet Documentation Improvement #1989

Merged
merged 8 commits into from
Jun 3, 2024
Merged

Stateful Storage Pallet Documentation Improvement #1989

merged 8 commits into from
Jun 3, 2024

Conversation

wilwade
Copy link
Collaborator

@wilwade wilwade commented May 29, 2024 •
edited
Loading

Goal

The goal of this PR is to improve the documentation of the Pallets and make that documentation be able to be used on docs.frequency.xyz.

Part of frequency-chain/docs#59

Discussion

  • Stateful Storage Pallet Readme

Screenshot

image

@wilwade wilwade mentioned this pull request May 29, 2024
Open
25 tasks
@codecov Codecov
Copy link

codecov bot commented May 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
pallets/stateful-storage/src/lib.rs 79.85% <100.00%> (ø)

jeanettedepatie
jeanettedepatie reviewed May 31, 2024
View reviewed changes
pallets/stateful-storage/README.md Outdated Show resolved Hide resolved
pallets/stateful-storage/README.md Outdated Show resolved Hide resolved
pallets/stateful-storage/README.md Outdated Show resolved Hide resolved
pallets/stateful-storage/README.md Outdated Show resolved Hide resolved
@wilwade wilwade marked this pull request as ready for review June 3, 2024 13:00
@wilwade wilwade requested review from a team, shannonwells, mattheworris, enddynayn, aramikm, claireolmstead and JoeCap08055 and removed request for a team June 3, 2024 13:00
JoeCap08055
JoeCap08055 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@JoeCap08055 JoeCap08055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

enddynayn
enddynayn approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 superb!

@jeanettedepatie
Copy link
Collaborator

Looks good! Ship it.

claireolmstead
claireolmstead approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@claireolmstead claireolmstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits/optional suggestions. 🚢

@wilwade wilwade enabled auto-merge (squash) June 3, 2024 17:53
@wilwade wilwade merged commit be6a41b into main Jun 3, 2024
28 checks passed
@wilwade wilwade deleted the docs/stateful-storage branch June 3, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanettedepatie jeanettedepatie jeanettedepatie left review comments

@JoeCap08055 JoeCap08055 JoeCap08055 approved these changes

@claireolmstead claireolmstead claireolmstead approved these changes

@enddynayn enddynayn enddynayn approved these changes

@shannonwells shannonwells Awaiting requested review from shannonwells shannonwells was automatically assigned from frequency-chain/pr-reviewers

@mattheworris mattheworris Awaiting requested review from mattheworris mattheworris was automatically assigned from frequency-chain/pr-reviewers

@aramikm aramikm Awaiting requested review from aramikm aramikm was automatically assigned from frequency-chain/pr-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wilwade @jeanettedepatie @enddynayn @claireolmstead @JoeCap08055