Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time Release Pallet Documentation Improvement #1978

Merged
merged 4 commits into from
May 23, 2024
Merged

Time Release Pallet Documentation Improvement #1978

merged 4 commits into from
May 23, 2024

Conversation

wilwade
Copy link
Collaborator

@wilwade wilwade commented May 22, 2024 •
edited
Loading

Goal

The goal of this PR is to improve the documentation of the Pallets and make that documentation be able to be used on docs.frequency.xyz.

Part of frequency-chain/docs#59

Discussion

  • Time Release Pallet (No RPCs for this pallet)
  • Small fixes in the template

Screenshot

image

@wilwade wilwade added the documentation Improvements or additions to documentation label May 22, 2024
enddynayn
enddynayn approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 fantastic!

@codecov Codecov
Copy link

codecov bot commented May 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
pallets/time-release/src/lib.rs 84.18% <100.00%> (ø)

@wilwade wilwade enabled auto-merge (squash) May 22, 2024 17:17
@wilwade wilwade mentioned this pull request May 22, 2024
Open
25 tasks
shannonwells
shannonwells approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 eet

@wilwade wilwade disabled auto-merge May 23, 2024 19:03
@wilwade wilwade merged commit fc1224d into main May 23, 2024
28 checks passed
@wilwade wilwade deleted the docs/time-release branch May 23, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanettedepatie jeanettedepatie jeanettedepatie approved these changes

@enddynayn enddynayn enddynayn approved these changes

@shannonwells shannonwells shannonwells approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wilwade @shannonwells @enddynayn @jeanettedepatie