Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new static header #96

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Conversation

wilwade
Copy link
Contributor

@wilwade wilwade commented Oct 31, 2024

Problem

Matching the header to the design

Closes #82

Solution

  • Static header added
  • JS to manage header open/closed state
  • Styles

with @claireolmstead

Screenshots (optional):

Screen Shot 2024-10-31 at 11 28 09-fullpage

Screen Shot 2024-10-31 at 11 28 17-fullpage

Screen Shot 2024-10-31 at 11 28 28-fullpage
Screen Shot 2024-10-31 at 11 28 35-fullpage
Screen Shot 2024-10-31 at 11 28 41-fullpage

Hovers:
image

image

Copy link
Contributor

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code changes and ran mdbook. There's about a 20px gap at 800px-819px where the mobile nav looks funny though, it's at an iPad width. I'm not sure if you want to fix it:
Screenshot 2024-10-31 at 9 10 02 AM

@wilwade
Copy link
Contributor Author

wilwade commented Oct 31, 2024

There's about a 20px gap at 800px-819px where the mobile nav looks funny though, it's at an iPad width.

Added to the tail end fixes: #87

@wilwade wilwade merged commit 36a9075 into developer-portal Oct 31, 2024
1 check passed
@wilwade wilwade deleted the 82-adding-new-static-header branch October 31, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants