Integration Domains: add tests to make sure Domains API works #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-trivino
force-pushed
the
domains-unit-tests
branch
3 times, most recently
from
afac279
to
c7a4b2b
Compare
f-trivino
force-pushed
the
domains-unit-tests
branch
from
c7a4b2b
to
c3d3ce5
Compare
f-trivino
force-pushed
the
domains-unit-tests
branch
20 times, most recently
from
2802be3
to
0999f5b
Compare
f-trivino
force-pushed
the
domains-unit-tests
branch
6 times, most recently
from
e3828e0
to
13458b9
Compare
f-trivino
force-pushed
the
domains-unit-tests
branch
6 times, most recently
from
776820d
to
f82f286
Compare
|
@flo-renaud this one is ready to be reviewed. |
f-trivino
force-pushed
the
domains-unit-tests
branch
from
f82f286
to
6373de6
Compare
This commit implements unit tests for the Integration Domains app to make sure the adapter (serializer), model, and view classes work as expected. The unit tests are using factory-boy library for creating the test data. Coverage: test domain __str__() method and adapter class so that the values for each of the fields in the serializer match the values for each of the fields on the model. Views unit tests are also added to make sure the domains API endpoints (GET, POST, and DELETE) work as expected. Signed-off-by: Francisco Trivino <[email protected]>
This commit adds more packages and system dependencies to the Dockerfile.test, now Containerfile.test, as well as running coverage and domains unit tests as entrypoint. This is used to test the image before uploading to quay.io. Signed-off-by: Francisco Trivino <[email protected]>
f-trivino
force-pushed
the
domains-unit-tests
branch
from
6373de6
to
03f4d17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements unit tests to make sure the app Domain model, adapter, and view works well. Initially using factory-boy and Faker libraries for creating the test data.
Coverage: test domain str() method and adapter class so that the values for each of the fields in the serializer match the values for each of the fields on the model. Views unit tests are also added to make sure the domains API endpoints (GET, POST, PUT, and PATCH) work as expected.