Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerfile: remove maven system dependency #109

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

f-trivino
Copy link
Collaborator

With this commit, a more recent version of Maven (version 3.8) is installed during the container build process. This version is accessible for C9S as a module, thus this commit enables the Maven 3.8 module stream.

@antoniotorresm
Copy link
Collaborator

Please add the change to prod/Containerfile as well. Also, why do we need maven? Maybe we could recheck every dependency.

This dependency is no longer needed.

Signed-off-by: Francisco Trivino <[email protected]>
@f-trivino f-trivino changed the title Containerfile: install maven 3.8 Containerfile: remove maven system dependency Apr 10, 2024
@f-trivino
Copy link
Collaborator Author

Please add the change to prod/Containerfile as well. Also, why do we need maven? Maybe we could recheck every dependency.

@antoniotorresm that's a great question, I think this dependency is no longer needed. It was added time ago when we were using helpers for the API, and now it is a leftover.

@antoniotorresm antoniotorresm merged commit 1885c01 into freeipa:main Apr 10, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants