Improve log in page button handling

[mreynolds389]

Disable the log in button while "logging in" is in progress, or if the username and password are empty

Fixes: #581

[carma12]

Please, check comment below.

[carma12]

Technically, the login button is still needed to login via Kerberos (it doesn't require to have any username or password filled, and in the case of authentication via Certificate it requires just the username). So I'm not sure if this specific lines are needed:

isLoginButtonDisabled={
   authenticating || username === "" || password === ""
}

[mreynolds389]

Ok that's fine, but the fields are marked as required in the UI. Should this be changed as well?

[carma12]

I'm sorry, I'm not sure what do you mean by 'required'.

Just to clarify, the username and password fields are initialized as empty and those are set and handled by the LoginForm component, so we are just passing the variables to it. As far as I know, there is no requirement that those values should be empty.

const loginForm = (
    <LoginForm
      showHelperText={showHelperText}
      helperText={errorMessage}
      helperTextIcon={<ExclamationCircleIcon />}
      usernameLabel="Username"
      usernameValue={username}             // <--- Here
      onChangeUsername={handleUsernameChange}
      isValidUsername={isValidUsername}
      passwordLabel="Password"
      passwordValue={password}              // <--- Here
      isShowPasswordEnabled
      onChangePassword={handlePasswordChange}
      isValidPassword={isValidPassword}
      onLoginButtonClick={onLoginButtonClick}
      loginButtonLabel="Log in"
      isLoginButtonDisabled={
        authenticating || username === "" || password === ""
      }
    />

[mreynolds389]

The UI form notes the fields as required via the asterisks , see attachment:

But I guess that can not be controlled. It's just misleading that's all

[carma12]

Oooh I see, thanks for clarifying. Yes, it seems to be something hardcoded in the PatternFly component. What I'm not sure if this is something that we can change at all. I will ask the PF team via Slack just in case.

[mreynolds389]

@carma12 I made the requested changes, please review...

[carma12]

LGTM.

I have also contacted the PatternFly team via Slack to ask them more information about the required username and password fields. It seems that they are open to provide a new parameter to the LoginPage component to allow disable those fields shown as required. Will keep you posted about it.