Fix available elements not shown in add #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carma12
force-pushed
the
available-elements-not-showing-add
branch
4 times, most recently
from
b191d2b
to
a89579e
Compare
Not all the available elements are being shown in the dual selector when opening the 'Add' modal, preventing those to be added. This is due to the limitation performed in the query when retrieving the elements that are not being assigned to a given user. Fixes: freeipa#348 Signed-off-by: Carla Martinez <[email protected]>
carma12
force-pushed
the
available-elements-not-showing-add
branch
from
a89579e
to
5a86f14
Compare
|
Temporary change LGTM, however, I would like to ask you to provide a tracking issue, so it is not lost. Thank you! |
Issue created to track the definitive changes to those tab sections: #358 |
|
Thank you, @carma12 , I am approving this PR. Happy merging! |
miskopo
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all the available elements are being shown in the dual selector when opening the 'Add' modal, preventing those to be
added. This is due to the limitation performed in the query when retrieving the elements that are not being assigned
to a given user.
This issue was affecting the following elements:
User groups,Netgroups.Fixes: #348