Adapt field permissions in 'Identity settings' #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on this one to be merged: #122 |
carma12
force-pushed
the
identity-settings-field-permissions
branch
2 times, most recently
from
e18540a
to
62340d2
Compare
This was referenced Jul 3, 2023
carma12
force-pushed
the
identity-settings-field-permissions
branch
from
62340d2
to
2c57fc4
Compare
carma12
force-pushed
the
identity-settings-field-permissions
branch
from
2c57fc4
to
22d94cf
Compare
pvoborni
requested changes
Jul 17, 2023
carma12
force-pushed
the
identity-settings-field-permissions
branch
from
22d94cf
to
584b0b9
Compare
|
The proposed solution has been already adapted (and squashed) in the existing code. |
carma12
force-pushed
the
identity-settings-field-permissions
branch
from
584b0b9
to
508f52c
Compare
|
This has also been rebased with the last changes merged on |
Field permissions have been provided to the fields of the 'Identity settings' section. This has been implemented by defining a new endpoint in the `rpc.ts` file. The data has been retrieved from a custom hook that is used in the `ActiveUsersTabs`, `StageUsersTabs`, and `PreservedUsersTabs` components. Finally, the `user` data in the `UserSettings` components has been replaced by the new `userData` from the API call. To hide internal details (that it is using a batch command) so that it returns the data as expected. Also, the batch command has been moved to the RPC wrapper. This way it is part of API end point and is using RTK Query build-in caching. Signed-off-by: Carla Martinez <[email protected]> Signed-off-by: Petr Vobornik <[email protected]>
carma12
force-pushed
the
identity-settings-field-permissions
branch
from
508f52c
to
b5662f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Field permissions have been provided to the fields of the 'Identity settings' section.
This has been implemented by defining a new endpoint in the
rpc.tsfile. The data has been retrieved from a custom hookthat is used in the
ActiveUsersTabs,StageUsersTabs, andPreservedUsersTabscomponents.Finally, the
userdata in theUserSettingscomponents has been replaced by the newuserDatafrom the API call.Signed-off-by: Carla Martinez [email protected]