Fix upstream CI and remove molecule #1300
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move Azure scripts to infra directory, as only roles and modules test playbooks should exist in the tests directory.
CentOS 7 containers are not working in recent versions of systemd.
The upstream CI tests can be simplified by using the script infra/image/start.sh to start the testing container and using a steps template playbook to prepare the environment. Although not required, the environment and test template separation aid on the future modification of the pipelines.
On Github and Azure, Ubuntu 22.04 images do not allow the selection of the CPU numbers.
For some time now, we had some issues with molecule when building test images for ansible-freeipa, and replaced the image creation with custom build scripts that use commom container tools (like Dockerfiles and the build command). As there's no more tasks that require the use of molecule, this patch removes the last bits used by it, and fixes documentation and lint scripts and configuration.
rjeffman
force-pushed
the
update_upstream_ci
branch
from
54c0735
to
908d8b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the last bits of dependency on molecule used for testing and image creation.
Upstream CI tests are fixed and updated to use
infra/image/start.shto run the containers, with some changes:teststoinfraThe whole Azure playbooks were redesigned so that we have only two "steps" files, one to setup the container, the other to actually run the tests. Configuration of different test types are done trough template parameters.
The TEMP commit is there just to show the PR Pipeline execution.
See pipeline runs at:
Note that when this PR is merged, all the Azure pipelines will need to be recreated.