New idview management module. #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-woerner
force-pushed
the
new_idview_module
branch
from
dedd995
to
331a75d
Compare
rjeffman
reviewed
Aug 24, 2023
t-woerner
force-pushed
the
new_idview_module
branch
2 times, most recently
from
5c501bc
to
1657069
Compare
varunmylaraiah
requested changes
Aug 31, 2023
t-woerner
force-pushed
the
new_idview_module
branch
2 times, most recently
from
b08a8d1
to
e7b1f29
Compare
rjeffman
approved these changes
Sep 5, 2023
| # But as we create the intersection with the list of hosts of | ||
| # the idview, we emulate the correct behaviour. But this means | ||
| # that there is no general idview_unapply like in the cli. | ||
| commands.append([None, "idview_unapply", {"host": host_del}]) |
There was a problem hiding this comment.
What do you think about "unapplying" a host within the ipahost plugin?
I'm thinking something like:
ipahost:
host: myhost
state: idview_unappliedI know it is a kind of behavior we still don't have in ansbile-freeipa, but it looks to me that "unapply" can be something defined from the host point of view.
I wouldn't change this plugin, but would provide ipahost a way to unapply from an idview.
(This would be a new PR.)
There was a problem hiding this comment.
The information is stored in the idview. It would require to have additional queries per host for idviews.
Maybe it would be possible to additionally have a generiac unapply for hosts as we have in the command line.
There is a new idview management module placed in the plugins folder:
plugins/modules/ipaidview.py
The idview module allows to ensure presence and absence of idviews and
idview host members.
Here is the documentation for the module:
README-idview.md
New example playbooks have been added:
playbooks/idview/idview-absent.yml
playbooks/idview/idview-host-applied.yml
playbooks/idview/idview-host-unapplied.yml
playbooks/idview/idview-present.yml
New tests for the module can be found at:
tests/idview/test_idview.yml
tests/idview/test_idview_client_context.yml
t-woerner
force-pushed
the
new_idview_module
branch
from
e7b1f29
to
ba4a360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new idview management module placed in the plugins folder:
The idview module allows to ensure presence and absence of idviews and idview host members.
Here is the documentation for the module:
New example playbooks have been added:
New tests for the module can be found at: