Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for npt #1057

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix for npt #1057

wants to merge 3 commits into from

Conversation

lessfoobar
Copy link

fix for ntp server. This way when you set the ntp_server or the pool it doesn't still take no_ntp

fix for ntp server. This way when you set the ntp_server or the pool it doesn't still take no_ntp
TASK [freeipa.ansible_freeipa.ipaclient : Install - IPA client test] ***********
fatal: [ipamaster.int.REDACTED.com]: FAILED! => {"changed": false, "msg": "--ntp-pool cannot be used together with --no-ntp"}
@lessfoobar
Copy link
Author

@t-woerner, @rjeffman could you guys have a look at this? Thanks in advance.

@rjeffman
Copy link
Member

Although you change fixes the issue, I'm not a fan of ternary(), as I find it hard to read and understand what it does.

@lessfoobar, I'm somewhat drowning in other issues right now, and giving your PR a proper review is on my TODO list. I hope to be able to look at it in the next week or the other.

@lessfoobar
Copy link
Author

okay, ping me up again when you have the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants