Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipauser: Add support for SMB attributes. #1056

Merged
merged 1 commit into from
Jul 17, 2023
Merged

ipauser: Add support for SMB attributes. #1056

merged 1 commit into from
Jul 17, 2023

Conversation

rjeffman
Copy link
Member

@rjeffman rjeffman commented Mar 7, 2023

Since FreeIPA version 4.8.0 ipauser has support for smb-logon-script, smb-profile-path, smb-home-dir, and smb-home-drive drive attributes.

This attributes are only available when modifying an existing user.

@rjeffman rjeffman added the DRAFT label Mar 8, 2023
@rjeffman rjeffman marked this pull request as ready for review April 11, 2023 16:50
@rjeffman rjeffman requested a review from t-woerner April 11, 2023 16:50
@rjeffman rjeffman removed the DRAFT label Apr 11, 2023
@rjeffman rjeffman changed the title [WIP] ipauser: Add support for SMB attributes. ipauser: Add support for SMB attributes. Apr 11, 2023
@rjeffman rjeffman requested a review from t-woerner July 10, 2023 23:41
@t-woerner
Copy link
Member

With this PR applied, I am getting this from ansible-test:

ERROR: Found 3 pep8 issue(s) which need to be resolved:
ERROR: plugins/modules/ipauser.py:825:5: E121: continuation line under-indented for hanging indent
ERROR: plugins/modules/ipauser.py:825:5: E125: continuation line with same indent as next logical line
ERROR: plugins/modules/ipauser.py:837:20: E231: missing whitespace after ','

@rjeffman
Copy link
Member Author

It interesting that pre-commit tests succeeded. I'll review those.

@rjeffman rjeffman requested a review from t-woerner July 13, 2023 11:10
@rjeffman rjeffman force-pushed the ipauser_smb_params branch 3 times, most recently from 16a841a to d6efb7a Compare July 14, 2023 13:51
@rjeffman
ipauser: Add support for SMB attributes.
57ad57d 
Since FreeIPA version 4.8.0 ipauser has support for smb-logon-script,
smb-profile-path, smb-home-dir, and smb-home-drive drive attributes.

On FreeIPA, these attributes are only available when modifying a user,
so if the user defined in the playbook does not exist, two calls to IPA
API are executed, a 'user_add' followed by a 'user_mod'.
(see https://github.com/freeipa/freeipa/blob/master/doc/designs/adtrust/samba-domain-controller.md

A new example playbook can be found at:

     playbooks/user/smb-attributes.yml

A new test playbook can be found at:

     tests/user/test_user_smb_attrs.yml
varunmylaraiah
varunmylaraiah approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@varunmylaraiah varunmylaraiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

t-woerner
t-woerner approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@t-woerner t-woerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-woerner t-woerner merged commit 411d363 into freeipa:master Jul 17, 2023
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunmylaraiah varunmylaraiah varunmylaraiah approved these changes

@t-woerner t-woerner t-woerner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjeffman @t-woerner @varunmylaraiah