Image io spi fix for newer Java than 8 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes background color when FreeHEP export dialog is used, where "jpeg" format name is used instead of "jpg".
…phics Conflicts: freehep-graphics2d/src/main/java/org/freehep/graphics2d/PixelGraphics2D.java (just catch Throwable instead of enumerating any possible exception)
Conflicts (trivial merge): freehep-graphicsio-pdf/src/main/java/org/freehep/graphicsio/pdf/PDFGraphics2D.java
… an ImageIO SPI class" issue by copying ServiceRegistry implementation from Java 8. The added source comes with "GPL v2 with classpath exception", making the whole project under this license.
murkle
suggested changes
Dec 10, 2020
|
@mikucionisaau you can't change the licence without permission from all previous contributors (and as there are no active maintainers that isn't going to happen 🤷♂️) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear maintainers,
this fixes FreeHEP usability issue under newer Java version>8.
The fix is rather crude and it mandates that the license should be changed from LGPL to GPL2 with classpath exception, which is very similar except it is meant for Java projects (LGPL talks about object files and static/dynamic linking -- mostly irrelevant in Java).
Best regards,
Marius