Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patches #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

patches #19

wants to merge 4 commits into from

Conversation

grimreaper
Copy link
Member

I thought I had push access to help with some cleanup & bug fixes - but meh

echo '' ; echo ' The proper location for this file is /usr/local/etc'
exit 1
fi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You previously committed this, but I reverted it. A user could easily incorrectly create /etc/portmaster.rc file and be confused why it doesn't work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then the error message should be changed. Most tools don't check for random files which happen to have the same name as their config file. Why not check in /usr/local/lib/portmasterrc ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just silly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly. I see no reason to retain the check for /etc/portmaster.rc; why not 'find / -name portmaster.rc' or 'locate portmaster.rc'
Most tools don't contain extra code to check for irrelevant files and I think the check here is mostly useless given that this support was removed 3 years ago.

That said, this mostly a pointless argument.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Portmaster is one of the first tools new users will encounter when coming to FreeBSD. The /usr/local/etc is very different than what they are likely used to. They are still likely to place a portmaster.rc file in /etc. It's completely disingenuous to suggest the user may put it into /usr/local/lib or $RANDOM_PLACE. There is absolutely 0 benefit to removing this check and >0 benefit to keeping it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants