Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass args to coverage and profiler #2592

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Pass args to coverage and profiler #2592

wants to merge 6 commits into from
+157 −28

Conversation

ksew1
Copy link
Collaborator

@ksew1 ksew1 commented Oct 18, 2024 •
edited
Loading

Closes software-mansion/cairo-coverage#80

Introduced changes

  • Users are now able to pass arguments to cairo-coverage and cairo-profiler
  • You can't use --coverage and --build-profile together

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@ksew1 ksew1 marked this pull request as draft October 18, 2024 15:43
ksew1
ksew1 commented Oct 18, 2024
View reviewed changes
CHANGELOG.md
- You can now pass arguments to `cairo-profiler` or `cairo-coverage`,
e.g. `snforge test --coverage --include tests-functions`. If flags name duplicates a flag in `snforge test`, you can
use `--` to separate them, e.g. `snforge test --coverage -- --help`
- You can't use now `--coverage` and `--build-profile` flags at the same time. If you want to use both, you need to run
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change this behavior to:

you can't use the --coverage and --build-profile flags if you are passing additional arguments

but it might confuse users. won't be having breaking change though

@ksew1 ksew1 marked this pull request as ready for review October 18, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@integraledelebesgue integraledelebesgue Awaiting requested review from integraledelebesgue integraledelebesgue is a code owner

@cptartur cptartur Awaiting requested review from cptartur cptartur is a code owner

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow passing args to cairo-coverage via snforge
1 participant
@ksew1