Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup/setup basic styling #34

Merged
merged 10 commits into from
Apr 16, 2019
Merged

Setup/setup basic styling #34

merged 10 commits into from
Apr 16, 2019

Conversation

hshahwan
Copy link
Contributor

relate #5

  • setup font family for titles and body.
  • add common colors for the app, that will help us in the styled components.

teenie-quaggard
teenie-quaggard reviewed Apr 16, 2019
View reviewed changes
Copy link
Contributor

@teenie-quaggard teenie-quaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question on the package.json - > didn't we move the eslint to the dependencies because of deployment issues?

@ali-7
Copy link
Contributor

ali-7 commented Apr 16, 2019 •
edited
Loading

@teenie-quaggard

One question on the package.json - > didn't we move the eslint to the dependencies because of deployment issues?

yes, eslint plugin that gives the problem, so i moved all the devDep to dep, but travis made an erro coz eslint library is a devDep >>> eslint-plugin-import, eslint-plugin-jsx-a11y

teenie-quaggard
teenie-quaggard approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@teenie-quaggard teenie-quaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I understand. Happy for these to be merged.

Oliversw
Oliversw approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@Oliversw Oliversw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, love the SVGs. Thanks!

@hshahwan hshahwan merged commit 3203c80 into development Apr 16, 2019
@hshahwan hshahwan deleted the setup/setup-basic-styling branch April 16, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oliversw Oliversw Oliversw approved these changes

@ali-7 ali-7 ali-7 approved these changes

@teenie-quaggard teenie-quaggard teenie-quaggard approved these changes

Assignees

@hshahwan hshahwan

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hshahwan @ali-7 @Oliversw @teenie-quaggard