-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UI): added manage group-users page #248
base: main
Are you sure you want to change the base?
feat(UI): added manage group-users page #248
Conversation
} from "services/groups"; | ||
|
||
import PropTypes from "prop-types"; | ||
import { userPermissions } from "../../../../constants/constants"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dushimsam can be imported directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
setShowMessage: PropTypes.func, | ||
}; | ||
|
||
const GroupCreate = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we have not created the other file for the GroupCreate function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
b42eb58
to
e22b654
Compare
Changes LGTM @dushimsam. Needs testing |
e22b654
to
429b07f
Compare
Alright , have added tests now. |
hello @dushimsam While testing this branch i have encountered the below error please check.
|
Tested Looks fine. but manage users should also have a functionality to add users to particular group. can you work on it @dushimsam |
sure sir, I am going to work on it as well. |
This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request. |
8f176b6
to
11a7e3e
Compare
4216de9
to
99fc3ce
Compare
This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request. |
99fc3ce
to
b06e0c5
Compare
b06e0c5
to
698b654
Compare
Signed-off-by: dushimsam <[email protected]>
698b654
to
9cd0e98
Compare
Description
Added Manage Group Users Page.
Changes
src/Routes.jsx
How to test
npm start
http://localhost:PORT/admin/group/manage
manage_group_users.mp4
Related Issue
Closing #242
cc: @shaheemazmalmmd @GMishx