Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to each function #159

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Add type hints to each function #159

merged 10 commits into from
Sep 5, 2024

Conversation

ParkSangsin
Copy link
Contributor

Description

Add type hints to each function.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Aug 5, 2024
Signed-off-by: ParkSangsin <[email protected]>
@soimkim
Copy link
Contributor

soimkim commented Aug 18, 2024

에러:

 def get_sheet_name(yaml_file: str, sheet_list: dict[str, list]) -> str:
TypeError: 'type' object is not subscriptable

아닛 이 버그는 다른 이슈네요!!!

typing 힌트에서 제너릭에 대한 지원은 Python 3.9부터 시작됩니다.
관련 문서는 PEP 585 (https://peps.python.org/pep-0585/) 에 있습니다.

파이썬 버전 수정은 불가하므로 from typing import Dict 로 수정이 필요해보입니다.

@soimkim soimkim mentioned this pull request Aug 18, 2024
5 tasks
@soimkim
Copy link
Contributor

soimkim commented Aug 25, 2024

@ParkSangsin 님, tox -e release로 에러 없는 상태를 만들어주세요. 😃

Signed-off-by: ParkSangsin <[email protected]>
@soimkim
Copy link
Contributor

soimkim commented Aug 30, 2024

@ParkSangsin , 9/3쯤 Prechecker 수정이 크게 있을 예정입니다.
이에 본 이슈 9/2까지 Merge되지 않으면 Conflict 가 많이 발생할 수 있는 점 참고 부탁드립니다.

Signed-off-by: ParkSangsin <[email protected]>
Signed-off-by: ParkSangsin <[email protected]>
Signed-off-by: ParkSangsin <[email protected]>
Signed-off-by: ParkSangsin <[email protected]>
@soimkim soimkim merged commit 0dce60c into fosslight:main Sep 5, 2024
5 checks passed
@soimkim
Copy link
Contributor

soimkim commented Sep 5, 2024

@ParkSangsin 님, 장기간 고생 많으셨습니다. 😄 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [PR/Issue] Refactoring, maintenance the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants