fix: always ask at least once for sourceMembers #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
when there were 0 expected sourceMembers (ex: you were only deploying a COT) there would no source tracking update.
start capturing in telemery the sourceMember changes we didnt' expect but received anyway. This will help avoid overly broad filters AND identify places where the ARE coming, but we're not expecting the correct name.
a bit of general cleanup
What issues does this PR fix or reference?
failures from just-nuts like https://github.com/salesforcecli/cli/actions/runs/5617978400/job/15223483795