Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support previewing with LWC Dev Server and LWR Server #78

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

maliroteh-sf
Copy link
Contributor

No description provided.

@maliroteh-sf maliroteh-sf requested a review from a team as a code owner October 26, 2023 17:33
@@ -4,4 +4,24 @@
* SPDX-License-Identifier: MIT
* For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
*/
export default {};

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-exporting everything b/c almost all of them are used in our other projects.

Copy link
Collaborator

@khawkins khawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the nit variable name update in All the Places, this looks fine to me. Thanks for finally exporting all our stuff! 😄

Copy link
Contributor

@sfdctaka sfdctaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maliroteh-sf maliroteh-sf merged commit 8f6aac2 into forcedotcom:main Oct 26, 2023
11 checks passed
@maliroteh-sf maliroteh-sf deleted the dep branch October 26, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants