Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend spec.summary to the github status message #427

Closed
wants to merge 1 commit into from
Closed

Prepend spec.summary to the github status message #427

wants to merge 1 commit into from

Conversation

alexkashintsev-tomtom
Copy link

Prepend Alert: spec.summary to the name of github notification.

I would like to use Flux notification to github which will show the badge on successfull/unsuccessfull reconciliation.
But I would like to modify message and include name of the region which was able to apply changes.

Currently Flux notification controller does not take into account configured summary of the alert.
By default if there is no summary in the metadata it will generate default status message.

if summary is provided Notifications controller will prepend it to the name of status: by doing this multiple regions can report to the same status in Github.

Prepend Alert: spec.summary to the name of github notification.

Signed-off-by: Alex Kashintsev <[email protected]>
@alexkashintsev-tomtom
Copy link
Author

alexkashintsev-tomtom commented Oct 6, 2022

Feels like dup of #340

@stefanprodan
Copy link
Member

This will break GH status update, the summary can have 1000+ characters. Given this we can't use the summary, we need a different API, see fluxcd/flux2#2639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants