Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to uninstall a HelmRelease even if it is suspended #568

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dippynark
Copy link

@dippynark dippynark commented Nov 25, 2022

We are using the Flux kustomize-controller and helm-controller to apply configuration to clusters. Before we make changes to HelmReleases and the ConfigMaps/Secrets that they reference we suspend all of the HelmReleases; this is so that the helm-controller doesn't try to upgrade a chart before all of the configuration is in place as this may make unexpected changes depending on the order the configuration is updated. Once the HelmRelease has been updated (via the kustomize-controller) and all of the other configuration is in place we unsuspend all the HelmReleases and wait for them to reconcile.

The issue we have is that if a HelmRelease is removed from an Kustomization (e.g. when rolling back a change) the HelmReleases are suspended and do not uninstall, leaving orphaned resources. To fix this, this PR adds an option to uninstall a HelmRelease even if it is suspended.

@dippynark dippynark force-pushed the allow-uninstall-when-suspended branch from 2340d98 to 5d85f0d Compare November 25, 2022 10:01
@dippynark dippynark changed the title feat: Allow HelmRelease uninstall even if suspended feat: Add option to uninstall a HelmRelease even if it is suspended Nov 25, 2022
@dippynark dippynark force-pushed the allow-uninstall-when-suspended branch from 2d27ab2 to 07347ae Compare November 25, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant