Loosen dependency check

Dependency checks do not account for upgrade ordering, so we only care about having the Ready condition set to True, no matter the observed generation. Signed-off-by: Stefan Prodan <[email protected]>
fluxcd · Jan 18, 2024 · dfe4058 · dfe4058
1 parent 5c340a1
commit dfe4058
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/internal/controller/helmrelease_controller.go b/internal/controller/helmrelease_controller.go
@@ -533,7 +533,7 @@ func (r *HelmReleaseReconciler) checkDependencies(ctx context.Context, obj *v2.H
  return fmt.Errorf("unable to get '%s' dependency: %w", ref, err)
  }
 
- if dHr.Generation != dHr.Status.ObservedGeneration || !conditions.IsTrue(dHr, meta.ReadyCondition) {
+ if !conditions.IsTrue(dHr, meta.ReadyCondition) {
  return fmt.Errorf("dependency '%s' is not ready", ref)
  }
  }