Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(integrations/registry): remove deprecated kustomize features #4395

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Stringls
Copy link

NOTE: Draft PR

Removing deprecated kustomize features as discussed here.

vars feature has not been removed as replacements cannot replace a var $() with the value patched outside the _base folder. I opened an issue in kustomize GitHub repository - link. I am awaiting for a response.

Also, besides removing deprecated kustomize features I also added missing files (e.g. kustomizeconfig.yaml to be able to use vars replacement in aws/ patch Deployment to specify a name of the secret with AWS credentials, etc.) and edited incorrect files.
I see the point why there were missing/incorrect files as on FluxCD website we suggest users to copy/paste the manifests and not to use those one stored in flux2 repository (perhaps we use these manifests somewhere else?). So it's fine if you'd like to revert the changes I made (adding new files).

I only updated registry-credentials-sync folder as there are already many changed files so you may wish to separate PRs so it's more convenient for you to review the PR. Please let me know your thoughts around that.

@Stringls Stringls force-pushed the replace-deprecated-kustomize-features branch from 0f38193 to e0dcd85 Compare November 10, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant