Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: lots of fixes for file descriptor leaks. #8371

Closed
wants to merge 3 commits into from

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Jan 13, 2024

Summary

This provides fixes for many different file descriptor leaks that affect flb_reload.

Most of them seem to be related to mk_event_channels which were never deallocated.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@edsiper
Copy link
Member

edsiper commented Jan 22, 2024

@pwhelan since the changes are in Master (v3) and 2.2 branch, is it same to drop it ?

#8371

@pwhelan
Copy link
Contributor Author

pwhelan commented Jan 22, 2024

Yes, this is in fact supersede entirely by #8392 and #8393, therefore I am closing it now.

@pwhelan pwhelan closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants