core: allow up to 32MB length of line buffer in read_config #7691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarruda
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
tarruda
force-pushed
the
tp/allow-arbitrary-config-line-lengths
branch
from
f05d2a1
to
70a13f6
Compare
tarruda
force-pushed
the
tp/allow-arbitrary-config-line-lengths
branch
from
70a13f6
to
827ee24
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
tarruda
force-pushed
the
tp/allow-arbitrary-config-line-lengths
branch
from
827ee24
to
090f8fe
Compare
tarruda
changed the title
read_config() to allow arbitrary lengths
tarruda
force-pushed
the
tp/allow-arbitrary-config-line-lengths
branch
from
090f8fe
to
974f15c
Compare
tarruda
force-pushed
the
tp/allow-arbitrary-config-line-lengths
branch
from
974f15c
to
53a4996
Compare
cosmo0920
force-pushed
the
tp/allow-arbitrary-config-line-lengths
branch
from
b3e3a58
to
78d88f5
Compare
cosmo0920
force-pushed
the
tp/allow-arbitrary-config-line-lengths
branch
from
dbb4779
to
909a68c
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
tp/allow-arbitrary-config-line-lengths
branch
from
909a68c
to
767b605
Compare
cosmo0920
changed the title
|
@cosmo0920 is this ok to go ? |
|
Yes. It's ready to go! |
Wiston999
pushed a commit
to Wiston999/fluent-bit
that referenced
this pull request
Aug 7, 2023
…#7691) --------- Signed-off-by: Thiago Padilha <[email protected]> Signed-off-by: Hiroshi Hatake <[email protected]> Co-authored-by: Hiroshi Hatake <[email protected]>
leonardo-albertovich
pushed a commit
that referenced
this pull request
Oct 5, 2023
--------- Signed-off-by: Thiago Padilha <[email protected]> Signed-off-by: Hiroshi Hatake <[email protected]> Co-authored-by: Hiroshi Hatake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently fluent-bit config file has an implicit line length limit of 4096 bytes, this modifies the
read_configto allow arbitrary line lengths.Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.