Controller - Operation handling -- WIP #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- message channel PR comments
…ution and updates on subscription operation for a subscription
Test Results219 tests 219 ✅ 43s ⏱️ Results for commit c210b37. ♻️ This comment has been updated with latest results. |
|
|
||
| public ShardAssigner(AssignmentStore assignmentStore) { | ||
| public ShardAssigner(AssignmentStore assignmentStore, MeterRegistry meterRegistry) { |
There was a problem hiding this comment.
meter registry is not being used, is that expected?
There was a problem hiding this comment.
yes. Metric addition is pending task and will be taken subsequently. Here we need to emit metrics around threadpool and associated tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some known error handling is pending.