Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scott MacVicar #23111

Merged
merged 8 commits into from
Oct 23, 2024
Merged

Add Scott MacVicar #23111

merged 8 commits into from
Oct 23, 2024

Conversation

Sampfluger88
Copy link
Member

image

@eashaw, can I get your help with this part?

  • Then make Scott's one of the default quotes on the device-management page, and on the contact form and wherever else eric shaw thinks it belongs.

fleet-release
fleet-release previously approved these changes Oct 23, 2024
@Sampfluger88 Sampfluger88 marked this pull request as ready for review October 23, 2024 01:51
@mike-j-thomas
Copy link
Member

@Sampfluger88, I think the image appears pixelated because of how GitHub is rendering the @2x image. Should render correctly on the actual site 👍

@Sampfluger88
Copy link
Member Author

@eashaw, I fixed the conflict here. Can you look it over when you get time?

@eashaw
Copy link
Contributor

eashaw commented Oct 23, 2024

@Sampfluger88 I updated the PR to change the quote on the contact, login, and signup pages and I updated the device management page to show this quote first. I will merge this PR when the website tests pass.

@eashaw eashaw merged commit 010f80d into main Oct 23, 2024
6 checks passed
@eashaw eashaw deleted the Sampfluger88-patch-8 branch October 23, 2024 17:06
jacobshandling pushed a commit that referenced this pull request Oct 25, 2024
<img width="330" alt="image"
src="https://github.com/user-attachments/assets/454df86f-bea8-4392-a50e-df84a68703f6">

@eashaw, can I get your help with this part?  
- [ ] Then make Scott's one of the default quotes on the
device-management page, and on the contact form and wherever else eric
shaw thinks it belongs.

---------

Co-authored-by: Eric <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants