Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Activity changes] Upcoming activities run as listed (one queue) and can be canceled #23075

Draft
wants to merge 3 commits into
base: docs-v4.60.0
Choose a base branch
from

Conversation

marko-lisica
Copy link
Member

@marko-lisica marko-lisica commented Oct 22, 2024

Related to: #22866

DON'T MERGE! Docs are auto-generated from code. Serves only as design for engineering team.

@marko-lisica
Copy link
Member Author

@rachaelshaw Could you take look at this when you get a chance? We're building a cancel feature for upcoming activity items on the host level. Does the naming make sense?

@rachaelshaw
Copy link
Member

rachaelshaw commented Oct 23, 2024

@marko-lisica taking a look. For future reference: if you want a prompt review on a draft PR, you'll need to request it manually: it's not super obvious in the GitHub UI, but the little moon icon next to the reviewers means they weren't actually requested for review yet.
Screenshot 2024-10-23 at 11 55 44 AM
(If you click the gear icon and select the reviewer in the list, it removes the moon icon and properly requests a review.)

@rachaelshaw rachaelshaw self-requested a review October 23, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants