Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https-listener-rules to test filtering unauthenticated endpoints #13895

Closed
wants to merge 8 commits into from

Conversation

rfairburn
Copy link
Contributor

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/ or orbit/changes/.
    See Changes files for more information.
  • Documented any API changes (docs/Using-Fleet/REST-API.md or docs/Contributing/API-for-contributors.md)
  • Documented any permissions changes (docs/Using Fleet/manage-access.md)
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added support on fleet's osquery simulator cmd/osquery-perf for new osquery data ingestion features.
  • Added/updated tests
  • Manual QA for all new/changed functionality
    • For Orbit and Fleet Desktop changes:
      • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
      • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

@rfairburn rfairburn requested review from edwardsb and a team as code owners September 12, 2023 21:39
@rfairburn rfairburn temporarily deployed to Docker Hub September 12, 2023 21:39 — with GitHub Actions Inactive
edwardsb
edwardsb previously approved these changes Sep 12, 2023
@rfairburn rfairburn temporarily deployed to Docker Hub September 12, 2023 21:59 — with GitHub Actions Inactive
@rfairburn rfairburn temporarily deployed to Docker Hub September 12, 2023 22:09 — with GitHub Actions Inactive
@rfairburn rfairburn temporarily deployed to Docker Hub September 12, 2023 22:09 — with GitHub Actions Inactive
georgekarrv
georgekarrv previously approved these changes Sep 12, 2023
@rfairburn rfairburn temporarily deployed to Docker Hub September 12, 2023 22:21 — with GitHub Actions Inactive
@rfairburn rfairburn temporarily deployed to Docker Hub September 12, 2023 22:21 — with GitHub Actions Inactive
georgekarrv
georgekarrv previously approved these changes Sep 12, 2023
lukeheath
lukeheath previously approved these changes Sep 12, 2023
@rfairburn rfairburn temporarily deployed to Docker Hub September 13, 2023 19:03 — with GitHub Actions Inactive
@rfairburn rfairburn temporarily deployed to Docker Hub September 13, 2023 19:03 — with GitHub Actions Inactive
georgekarrv
georgekarrv previously approved these changes Sep 13, 2023
Copy link
Member

@georgekarrv georgekarrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to have all 6 exceptions in one rule? otherwise this looks good

@rfairburn
Copy link
Contributor Author

any reason not to have all 6 exceptions in one rule? otherwise this looks good

AWS returned an error once I had too many * in a single rule. This is to avoid hitting the wildcard limit.

lukeheath
lukeheath previously approved these changes Sep 13, 2023
@lukeheath
Copy link
Member

Merge Gatekepper is saying this job failed:

  • Deploy Fleet Dogfood Environment

But I don't see it in the list of jobs.

@lukeheath
Copy link
Member

@rfairburn Feel free to squash and merge with gatekepeer failing. Looks like it's looking for a dogfood publish job that isn't running.

@rfairburn
Copy link
Contributor Author

I don't intend to ever merge this.

@rfairburn
Copy link
Contributor Author

Originally this was for visibility while everyone was working so that I could share the diff I was applying, but this shouldn't permanently be part of dogfood. I will close it once we have what we want working for the customer.

@rfairburn rfairburn temporarily deployed to Docker Hub September 13, 2023 20:02 — with GitHub Actions Inactive
@rfairburn rfairburn temporarily deployed to Docker Hub September 13, 2023 20:02 — with GitHub Actions Inactive
@rfairburn
Copy link
Contributor Author

closing this since we don't want it permanently in main.

@rfairburn rfairburn closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants