Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add history mode guide #49

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Add history mode guide #49

wants to merge 14 commits into from

Conversation

fivetran-abdulsalam
Copy link
Contributor

@fivetran-abdulsalam fivetran-abdulsalam commented Jun 18, 2024

Closes https://fivetran.height.app/T-724858

Description
Added history mode guide

Copy link
Collaborator

@manjutapali manjutapali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Please get review from @5tran-alexil.

how-to-handle-history-mode-files.md Outdated Show resolved Hide resolved
how-to-handle-history-mode-files.md Outdated Show resolved Hide resolved
how-to-handle-history-mode-files.md Outdated Show resolved Hide resolved
@fivetran-abdulsalam fivetran-abdulsalam requested a review from a team June 18, 2024 11:30
development-guide.md Outdated Show resolved Hide resolved
Copy link
Contributor

@5tran-alexil 5tran-alexil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-abdulsalam throughout the files, add articles using the suggestiuons as references, add "as follows" to "will be", add the relevant actor ("we" or "you need to" in sentences like:
"Check for corresponding earliest record(_fivetran_earliest TRUE), DELETE the existing records from destination table if _fivetran_start of destination table is greater than or equal to _fivetran_start of batch file(in above example yes, so deleted id = 1 with _fivetran_start = T3 and T4)"

Copy link
Contributor

@5tran-alexil 5tran-alexil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a series if edits

@fivetran-abdulsalam fivetran-abdulsalam marked this pull request as draft July 8, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants